kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 67 forks source link

k8s watcher should use structured logging #245

Closed jlewi closed 3 years ago

jlewi commented 4 years ago

/kind feature

The watcher should use structured logging. We should use [logr][https://github.com/go-logr/logr) as an abstract logging interface with zap as the actual implementation.

This will allow us to emit structured logs (i.e. json records). Using structured logs we attach metadata as key/value pairs; e.g we can log the name, uid, etc.. of the objects being handled. Structured logs will make it easy to make sense of the logs because we will be able to filter to see log entries about a particular object

jlewi commented 4 years ago

/cc @Swikar