Closed jlewi closed 3 years ago
I can help review the PR.
/assign @Jeffwan
Test flakes should be fixed by #251
@jlewi: The following test failed, say /retest
to rerun all failed tests:
Test name | Commit | Details | Rerun command |
---|---|---|---|
kubeflow-metadata-presubmit | 62c836879ee430b7ac1fc4268171ec6fe20f24ae | link | /test kubeflow-metadata-presubmit |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Jeffwan, jlewi
To complete the pull request process, please assign neuromage after the PR has been reviewed.
You can assign the PR to them by writing /assign @neuromage
in a comment when ready.
The full list of commands accepted by this bot can be found here.
I'm closing this because I no longer have merge rights and I'm not sure what's going on with metadata anymore.
Sure
On May 3, 2021, at 6:28 AM, Jeremy Lewi @.***> wrote:
I'm closing this because I no longer have merge rights and I'm not sure what's going on with metadata anymore.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.
K8s objects will now be logged as executions instead of artifacts
The watcher looks for annotations defining inputs and outputs
The net result is that we can generate lineage graphs just by attaching annotations to K8s object.
The current implementation is pretty primitive; there are a number of issues to fix in follow ups
Handling multiple inputs and outputs
Handling the case where there already artifacts in the DB corresponding to the annotations
Right now a new artifact is created for each resource.
Add an example job that we can use to test things.
Miscellaneous fixes
For the watcher add Makefile rules to build with GCB
Check in the generated go client libraries for the metadata service.
Update watcher deployment to v1.
Change the resource_list.json to watch jobs not pods/services by default.
Related to: #241
/assign @karlschriek /assign @Swikar