kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 69 forks source link

Get Rid Of the Standalone Metadata UI #250

Closed jlewi closed 2 years ago

jlewi commented 3 years ago

/kind feature

Right now there are two metadata UIs.

  1. Built into KFP (i.e. the Execution and Artifacts view inside KFP)
  2. A standalone version of the UI for metadata

The standalone UI has fallen behind and per #225 it doesn't look like anyone will be maintaining it. So it looks like we should get rid of it. It looks like the work items are

@yanniszark @kimwnasptd I believe you will be the ones maintaining the centraldashboard could you take a look at removing the artifact store link?

@kubeflow/wg-pipeline-leads Is there someone on the KFP side that could looking into cleanup up the metadata K8s manifest?

Related to #225

Jeffwan commented 3 years ago

@jlewi

em. How does user check artifact if user uses metadata outside KFP? Should we redirect them to KFP pipeline UI?

I think there're some users use SDK to log_params like this way. https://github.com/kubeflow/metadata/blob/master/sdk/python/sample/demo.ipynb

Bobgy commented 3 years ago

@Jeffwan do you have contact with such users? I think if the existing UI works for them, we can keep it until KFP can provide sth that's a superset of its features and replace it.

But I kind of doubt if users can successfully use that UI, because it suffers from the same scalability issue KFP artifact list is having: there was no pagination for the artifact list request, so the UI could only show everything in one list. When artifact count is getting larger, the page will start to break.

jlewi commented 3 years ago

Should we redirect them to KFP pipeline UI?

Yes. I checked and Executions and Artifacts not logged through KFP still show up there.

Jeffwan commented 3 years ago

@Jeffwan do you have contact with such users? I think if the existing UI works for them, we can keep it until KFP can provide sth that's a superset of its features and replace it.

But I kind of doubt if users can successfully use that UI, because it suffers from the same scalability issue KFP artifact list is having: there was no pagination for the artifact list request, so the UI could only show everything in one list. When artifact count is getting larger, the page will start to break.

@Bobgy I don't have a list. We suggested AWS users to consider this solution for tracking purpose and built some tutorials in the workshops. I don't know how many users are really on it. I think if we think KFP UI is the replacement, it makes sense to remove the one from central dashboard.

Bobgy commented 3 years ago

Should we redirect them to KFP pipeline UI?

Yes. I checked and Executions and Artifacts not logged through KFP still show up there.

Right, in this case we can get rid of metadata UI

Bobgy commented 3 years ago

I will update k8s metadata manifest

Bobgy commented 3 years ago

@Jeffwan @jlewi I want to confirm, are there still dependents of metadata-server? https://github.com/kubeflow/manifests/blob/729e3cda92b7c8656441480995da6fd0a9a18ce3/metadata/overlays/db/metadata-deployment.yaml#L4

KFP is not depending on it, KFP uses metadata-grpc-server directly

Jeffwan commented 3 years ago

@Bobgy I think it would be great to keep them. I think SDK use http endpoint, if we remove HTTP deployment, SDK should be deprecated as well.

User can still use SDK and check artifacts in pipeline manifest UI. We need to have more discussion on the roadmap. Before we have the conclusion, I would suggest to only delete UI components

Bobgy commented 3 years ago

I see, if we cannot remove http endpoint, then we cannot remove UI server yet.

neuromage commented 3 years ago

We would like to suggest we delete both SDK and UI here. Instead, we can consolidate this within KFP, where there is already a UI for metadata. Furthermore, we'd like to propose that we add SDK features directly into KFP SDK instead, hence allowing users to use one SDK to both construct pipelines, and query metadata from their notebooks.

We have outlined a proposal here, to be discussed during the upcoming community meeting: https://docs.google.com/document/d/1YhnsMK_ktaeUKLS2XShocq4u2bcUCUcztT9rioRssOM/edit#

Would love your feedback!

Jeffwan commented 3 years ago

Great. If KFP already have a plan. We can deprecate UI server and SDK together along with frontend. @Bobgy Can you update the manifest PR?

Bobgy commented 3 years ago

OK, SGTM

Bobgy commented 3 years ago

@kubeflow/wg-notebook-leads Will you be able to remove the metadata tab from central dashboard?

Bobgy commented 3 years ago

/reopen Left over is the entry in central dashboard. /assign @kubeflow/wg-notebook-leads

k8s-ci-robot commented 3 years ago

@Bobgy: Reopened this issue.

In response to [this](https://github.com/kubeflow/metadata/issues/250#issuecomment-725708918): >/reopen >Left over is the entry in central dashboard. >/assign @kubeflow/wg-notebook-leads Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Jeffwan commented 3 years ago

I file a PR to remove the link in central dashboard

muthurajr commented 3 years ago

@jlewi @Bobgy I created a separate issue for Metadata deployments in google-cloudsql. https://github.com/kubeflow/manifests/issues/1692

Hope its related this issue as well.

Bobgy commented 3 years ago

Transferred the issue to https://github.com/kubeflow/gcp-blueprints/issues/182