kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 67 forks source link

Replace obsolete ksonnet tests with Tekton. #251

Closed jlewi closed 4 years ago

jlewi commented 4 years ago

Related to #247

kubeflow-bot commented 4 years ago

This change is Reviewable

jlewi commented 4 years ago

/assign @karlschriek /assign @Swikar

Jeffwan commented 4 years ago

I am working on ML tracking related stories recently. I can help put some time review the code changes :D

jlewi commented 4 years ago

Thanks @Jeffwan; PTAL

Jeffwan commented 4 years ago

/lgtm

jlewi commented 4 years ago

/approve

jlewi commented 4 years ago

/assign @avdaredevil

Jeffwan commented 4 years ago

/lgtm

If OWNERS are not active, we can manually squash and merge PR.

avdaredevil commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avdaredevil, Jeffwan, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/metadata/blob/master/OWNERS)~~ [avdaredevil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment