kubeflow / metadata

Repository for assets related to Metadata.
Apache License 2.0
121 stars 67 forks source link

[UI] Add lineage sections to Model Detail views #81

Open prodonjs opened 5 years ago

prodonjs commented 5 years ago

/kind feature /area front-end

Retrieve and display related Data Set and Evaluation metrics for Models.

Mocks

prodonjs commented 5 years ago

@zhenghuiwang Can you point me to any guidance or documentation on how we might be able to use the new events API methods you added in #53?

For example, using the data in https://kubeflow-v-n00.endpoints.zhenghui-kubeflow-2.cloud.goog: /api/v1alpha1/artifact_types/kubeflow.org/alpha/model/artifacts/40 is the model in question.

/api/v1alpha1/events/artifacts/40 gives back

{
   "events":[
      {
         "artifact_id":"40",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383006"
      }
   ]
}

Then, using the execution_id from the returned event, /api/v1alpha1/events/executions/12 returns

{
   "events":[
      {
         "artifact_id":"39",
         "execution_id":"12",
         "type":"INPUT",
         "milliseconds_since_epoch":"1562114382971"
      },
      {
         "artifact_id":"40",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383006"
      },
      {
         "artifact_id":"41",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383042"
      }
   ]
}

Would we then need to go about determining the type of each artifact listed there and retrieving them individually or is there something I am missing?

zhenghuiwang commented 5 years ago

You're right. It is a problem: the response doesn't have type info about the artifacts&executions hence you can't retrieve each individual artifact&execution.

Proposed fix: I will add response field artifacts: map from id to artifact, and field executions similarly.

prodonjs commented 5 years ago

blocked by #84

zhenghuiwang commented 5 years ago

/reopen

PR#84 is merged and I've updated our dev KF cluster to master. You should see the artifact&execution map in the ListEvent response now.

k8s-ci-robot commented 5 years ago

@zhenghuiwang: Reopened this issue.

In response to [this](https://github.com/kubeflow/metadata/issues/81#issuecomment-509414379): >/reopen > >PR#84 is merged and I've updated our dev KF cluster to master. You should see the artifact&execution map in the ListEvent response now. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jtfogarty commented 4 years ago

/kind feature /priority p2

k8s-ci-robot commented 4 years ago

@jtfogarty: The label(s) area/feature cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/kubeflow/metadata/issues/81#issuecomment-574398904): >/area feature >/priority p2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.