kubeflow / model-registry

Apache License 2.0
76 stars 42 forks source link

Small cleanup on cypress gitignore #408

Closed ederign closed 1 week ago

ederign commented 1 week ago

Description

Some GHA are failing due to lack of cleanup of downloads folder: https://github.com/kubeflow/model-registry/actions/runs/10948937500/job/30401082009?pr=403

@isinyaaa gently provided a quick fix. This PR is just some FUP PR for our better code organization.

How Has This Been Tested?

Merge criteria:

ederign commented 1 week ago

@Griffin-Sullivan can you please take a look over this one?

alexcreasy commented 1 week ago

/lgtm

alexcreasy commented 1 week ago

/approve

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[clients/ui/OWNERS](https://github.com/kubeflow/model-registry/blob/main/clients/ui/OWNERS)~~ [alexcreasy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment