kubeflow / model-registry

Apache License 2.0
76 stars 42 forks source link

Add views for Model Versions and Model Details #409

Closed Griffin-Sullivan closed 1 week ago

Griffin-Sullivan commented 1 week ago

Description

Adding all Screens, Components, and Cypress tests for Model details and versions table. I've also added a Jest unit test for some helpers that were added in a previous PR. Also note a small addition to our tsconfig to get around an issue I saw in VS Code.

Screenshot from 2024-09-20 11-05-04 Screenshot from 2024-09-20 11-05-17 Screenshot from 2024-09-20 11-08-28

How Has This Been Tested?

Manually testing the UI in mock mode Jest and Cypress tests

Merge criteria:

If you have UI changes

google-oss-prow[bot] commented 1 week ago

@lucferbux: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeflow/model-registry/pull/409#pullrequestreview-2325670315): >/lgtm > >I've left a couple of nits but some of them should be addressed in the follow up PR, current one is working as expected. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[clients/ui/OWNERS](https://github.com/kubeflow/model-registry/blob/main/clients/ui/OWNERS)~~ [alexcreasy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment