Fix disabled text color on DescriptionListDescription

Griffin-Sullivan commented 5 days ago

Description

In my last PR I was using text.iconColorSubtle to get around the disabled color being to low of a color ratio on a white background. It was causing our a11y testing to fail. Turns out you don't need to pass color contrast ratios on disabled elements so conditionally adding the aria-disabled attribute will cause the tests to pass.

The color change is probably not noticeable enough to anyone but can add an image if requested.

How Has This Been Tested?

Running cypress mock tests

Merge criteria:

All the commits have been signed-off (To pass the DCO check)

[x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[x] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

[ ] The developer has added tests or explained why testing cannot be added.
[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

google-oss-prow[bot] commented 2 days ago

@lucferbux: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeflow/model-registry/pull/434#pullrequestreview-2336634743): >/lgtm > >Ok this is great, I would imagine this is gonna happen again soon, we should track this and make sure we port it in other places. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Griffin-Sullivan commented 2 days ago

@lucferbux I added a comment to the PF6 SPIKE so people will be aware when swapping to PF6.

google-oss-prow[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[clients/ui/OWNERS](https://github.com/kubeflow/model-registry/blob/main/clients/ui/OWNERS)~~ [ederign] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubeflow / model-registry