search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Upgrade Kubernetes dependencies #502

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

I upgraded Kubernetes dependencies.

Fixes: #483

alculquicondor commented 1 year ago

/lgtm

tenzen-y commented 1 year ago

Thanks for the review!

/assign @terrytangyuan

tenzen-y commented 1 year ago

@alculquicondor I forgot to re-generate go client codes. PTAL

tenzen-y commented 1 year ago

Something is wrong...

tenzen-y commented 1 year ago

@alculquicondor The code-generator seems unable to generate client codes since we have a different Go module name, github.com/kubeflow/mpi-operator/v2, and directory structure, github.com/kubeflow/mpi-operator.

So we need to change the Go module name to github.com/kubeflow/mpi-operator or move all codes to the directory github.com/kubeflow/mpi-operator/v2.

The latter means we revert #496.

WDYT?

alculquicondor commented 1 year ago

Interesting. I guess that's not a problem in k8s.io/klog.

I'm fine with changing the module name. I wouldn't expect users of the internal packages, right?

tenzen-y commented 1 year ago

Interesting. I guess that's not a problem in k8s.io/klog.

As I can see, the k8s.io/klog does not generate the k8s client code by code-generator. So k8s.io/klog does not face the same issue.

I'm fine with changing the module name. I wouldn't expect users of the internal packages, right?

Yes, I think so too.

alculquicondor commented 1 year ago

Consider splitting the module rename in a separate PR.

tenzen-y commented 1 year ago

Consider splitting the module rename in a separate PR.

Makes sense.

tenzen-y commented 1 year ago

@alculquicondor I have rebased and squashed. PTAL.

alculquicondor commented 1 year ago

Please squash. LGTM otherwise

tenzen-y commented 1 year ago

@alculquicondor Squashed.

alculquicondor commented 1 year ago

/lgtm

tenzen-y commented 1 year ago

/assign @terrytangyuan

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment