search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

[WIP] Generate the all-in-one manifest #509

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

I forgot to re-generate deploy/v2beta1/mpi-operator.yaml when I upgraded the kubernetes dependencies. So I re-generate that manifest with kustomize build manifests/overlays/standalone/.

Fixes: #508

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rongou for approval by writing /assign @rongou in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

Could we add a diff check in the CI?

Makes sense. Yes, sure.

tenzen-y commented 1 year ago

Blocked by #510

tenzen-y commented 1 year ago

I include these changes in #510.

/close

google-oss-prow[bot] commented 1 year ago

@tenzen-y: Closed this PR.

In response to [this](https://github.com/kubeflow/mpi-operator/pull/509#issuecomment-1408972533): >I include these changes in #510. > >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.