kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Clean up manifests #510

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

I cleaned up manifests in the following:

  1. Replace the image tag with 'master' to avoid this confusing.
  2. Update the make crd target so that we can add the latest CRD to the manifests directory.
  3. Regenerate deploy/v2beta1/mpi-operator.yaml.
  4. Update the Readme.md.
  5. Add CI to verify generated codes.

Our operator images at dockerhub:

Fixes: #508

tenzen-y commented 1 year ago

/assign @terrytangyuan

tenzen-y commented 1 year ago

@terrytangyuan Or we push the latest image with latest tag by changing Ci?

https://github.com/kubeflow/mpi-operator/blob/05ac6addc0830e34c01a6cb13c25e25ac7f81fe6/.github/workflows/mpi-operator-docker-image-publish.yml#L29-L33

cc: @alculquicondor


Updated

I modified the CI to push the latest image with the latest image tag.

tenzen-y commented 1 year ago

@alculquicondor Updated.

alculquicondor commented 1 year ago

Can we update https://github.com/kubeflow/mpi-operator#installation to indicate that this will install the latest development version?

:latest is still the latest release, 0.3.0. I wonder if we should have stored those manifests somewhere for users reference. Can we still add them as a release asset? @terrytangyuan

tenzen-y commented 1 year ago

Can we update https://github.com/kubeflow/mpi-operator#installation to indicate that this will install the latest development version?

Makes sense. It is helpful.

tenzen-y commented 1 year ago

@alculquicondor I updated the docs.

tenzen-y commented 1 year ago

Blocked by #514

tenzen-y commented 1 year ago

@alculquicondor This PR is ready for review. PTAL.

tenzen-y commented 1 year ago

Addressed comments and squashed commits into one.

alculquicondor commented 1 year ago

/lgtm

alculquicondor commented 1 year ago

/assign @terrytangyuan

tenzen-y commented 1 year ago

@terrytangyuan Can you add a approve label to this PR? We need this improvement for the v0.4.0 release.

alculquicondor commented 1 year ago

Let me try my new powers :joy:

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

Let me try my new powers 😂

/approve

Great power 🚀