Closed tenzen-y closed 1 year ago
/assign @terrytangyuan
@terrytangyuan Or we push the latest image with latest
tag by changing Ci?
cc: @alculquicondor
Updated
I modified the CI to push the latest image with the latest
image tag.
@alculquicondor Updated.
Can we update https://github.com/kubeflow/mpi-operator#installation to indicate that this will install the latest development version?
:latest
is still the latest release, 0.3.0
. I wonder if we should have stored those manifests somewhere for users reference. Can we still add them as a release asset? @terrytangyuan
Can we update https://github.com/kubeflow/mpi-operator#installation to indicate that this will install the latest development version?
Makes sense. It is helpful.
@alculquicondor I updated the docs.
Blocked by #514
@alculquicondor This PR is ready for review. PTAL.
Addressed comments and squashed commits into one.
/lgtm
/assign @terrytangyuan
@terrytangyuan Can you add a approve label to this PR? We need this improvement for the v0.4.0 release.
Let me try my new powers :joy:
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alculquicondor
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Let me try my new powers 😂
/approve
Great power 🚀
Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com
I cleaned up manifests in the following:
make crd
target so that we can add the latest CRD to the manifests directory.deploy/v2beta1/mpi-operator.yaml
.Our operator images at dockerhub:
latest
: https://hub.docker.com/layers/mpioperator/mpi-operator/latest/images/sha256-3ccfa8d8b7bf97836b291f5cadb39afec4b3612acddb4a5f81ecccdfaede92f9?context=exploremaster
: https://hub.docker.com/layers/mpioperator/mpi-operator/master/images/sha256-84749d84196f15fa61b2a2786ae625b4b85dd750dd4dd5e39970d4985ebfc70a?context=exploreFixes: #508