search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Add scheduling.volcano.sh to ClusterRole #512

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

We need to use scheduling.volcano.sh for PodGroup and Queue in the latest volcano release. So we need to add scheduling.volcano.sh to avoid the following errors:

E0127 18:20:53.426562 1 reflector.go:140] pkg/mod/k8s.io/client-go@v0.25.6/tools/cache/reflector.go:169: Failed to watch v1beta1.PodGroup: failed to list v1beta1.PodGroup: podgroups.scheduling.volcano.sh is forbidden: User "system:serviceaccount:mpi-operator:mpi-operator" cannot list resource "podgroups" in API group "scheduling.volcano.sh" at the cluster scope

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment