kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Add alculquicondor to approvers #515

Closed alculquicondor closed 1 year ago

alculquicondor commented 1 year ago

I nominate myself as a approver, given my contributions:

alculquicondor commented 1 year ago

/assign @terrytangyuan

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

+1

@terrytangyuan Do we have any blocking?

gaocegege commented 1 year ago

/lgtm

johnugeorge commented 1 year ago

Great work @alculquicondor

terrytangyuan commented 1 year ago

/hold cancel

terrytangyuan commented 1 year ago

Congrats! @alculquicondor Thank you for your contributions!

alculquicondor commented 1 year ago

Thank you all!