search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Pass context to the utility methods in e2e tests #516

Closed mimowo closed 1 year ago

mimowo commented 1 year ago

This is a follow up PR to cleanup the recently touched utility methods in e2e tests.

See for context: https://github.com/kubeflow/mpi-operator/pull/511#discussion_r1094813525.

mimowo commented 1 year ago

/assign @terrytangyuan

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment