search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

WIP: Use the Kueue ignore annotation #521

Closed mimowo closed 1 year ago

mimowo commented 1 year ago

WIP because we want the Kueue PR (https://github.com/kubernetes-sigs/kueue/pull/558) to merge first to make sure the annotation name is correct.

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 1 year ago

/close With the new proposal no changes are needed in mpi-operator. The parent-workload annotation (a replacement for ignore, see: https://github.com/kubernetes-sigs/kueue/pull/558#discussion_r1101935841) will be added by a webhook registered by code in Kueue.

google-oss-prow[bot] commented 1 year ago

@mimowo: Closed this PR.

In response to [this](https://github.com/kubeflow/mpi-operator/pull/521#issuecomment-1425545720): >/close >With the new proposal no changes are needed in mpi-operator. The `parent-workload` annotation (a replacement for `ignore`, see: https://github.com/kubernetes-sigs/kueue/pull/558#discussion_r1101935841) will be added by a webhook registered by code in Kueue. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.