search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

Stop using k8s.io/sample-controller #529

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

I replaced the signals.SetupSignalHandler() from k8s.io/sample-controller with kubeapiserver.SetupSignalHandler() from k8s.io/apiserver/pkg/server.

Fixes: #367

alculquicondor commented 1 year ago

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

@gaocegege @alculquicondor, can you also add a lgtm label to this PR?

alculquicondor commented 1 year ago

oops /lgtm