Closed tenzen-y closed 1 year ago
I will add the integration tests to this PR.
PTAL /assign @alculquicondor
I wonder if @denkensk could give a sanity check as one of the authors of the coscheduling plugin.
I wonder if @denkensk could give a sanity check as one of the authors of the coscheduling plugin.
@alculquicondor Thank you for the review! I'd be happy if this PR is reviewed by @denkensk.
/lgtm /hold for @denkensk
/lgtm
can you squash?
/approve
@alculquicondor Squashed.
/approve
leaving lgtm to @denkensk
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alculquicondor
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Thanks for your contribution. @tenzen-y
/unhold
I added the implementation for the coscheduling plugin of kubernetes-sigs/scheduler-plugins.
ref: https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/coscheduling
So I modified the following:
Follow ups:
Part-of: #500