kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
420 stars 211 forks source link

Support the coscheduling plugin of scheduler-plugins #538

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

I added the implementation for the coscheduling plugin of kubernetes-sigs/scheduler-plugins.

ref: https://github.com/kubernetes-sigs/scheduler-plugins/tree/master/pkg/coscheduling

So I modified the following:

Follow ups:

Part-of: #500

tenzen-y commented 1 year ago

I will add the integration tests to this PR.

PTAL /assign @alculquicondor

alculquicondor commented 1 year ago

I wonder if @denkensk could give a sanity check as one of the authors of the coscheduling plugin.

tenzen-y commented 1 year ago

I wonder if @denkensk could give a sanity check as one of the authors of the coscheduling plugin.

@alculquicondor Thank you for the review! I'd be happy if this PR is reviewed by @denkensk.

alculquicondor commented 1 year ago

/lgtm /hold for @denkensk

alculquicondor commented 1 year ago

/lgtm

alculquicondor commented 1 year ago

can you squash?

/approve

tenzen-y commented 1 year ago

@alculquicondor Squashed.

alculquicondor commented 1 year ago

/approve

leaving lgtm to @denkensk

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
denkensk commented 1 year ago

/lgtm

Thanks for your contribution. @tenzen-y

denkensk commented 1 year ago

/unhold