kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

Add versioned labels to images #545

Closed alculquicondor closed 1 year ago

alculquicondor commented 1 year ago

Base and test images should include the version as part of the label

alculquicondor commented 1 year ago

/assign @tenzen-y

tenzen-y commented 1 year ago

/lgtm

tenzen-y commented 1 year ago

Why an approved label isn't added to this PR 🤔

alculquicondor commented 1 year ago

/approve ?

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

I wonder why a PR creator can add approved labels to their PR.

alculquicondor commented 1 year ago

I wonder why a PR creator can add approved labels to their PR.

Only because I'm an approver. It works the same way in k8s

tenzen-y commented 1 year ago

I wonder why a PR creator can add approved labels to their PR.

Only because I'm an approver. It works the same way in k8s

Ah, I see.