search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

Commonize function newCleanPodPolicy() #557

Closed tenzen-y closed 1 year ago

tenzen-y commented 1 year ago

Currently, we have duplicated functions to create a pointer for the CleanPodPolicy . That situation could be more efficient. So I commonized the function newCleanPodPolicy().

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

@terrytangyuan Thank you for the review. Can you restart build / E2E (v1.26.3) (pull_request)?