kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

merge kubeflow/common.v1 to mpi-operator #571

Closed lowang-bh closed 1 year ago

lowang-bh commented 1 year ago

Fix #564

TODO:

hack/python-sdk/gen-sdk.sh
Generating V2 OpenAPI specification ...
Generating V2 swagger file ...
Downloading the swagger-codegen JAR package ...
Generating V2 Python SDK for Kubeflow MPI-Operator ...
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com for information on installing Java.
lowang-bh commented 1 year ago

@terrytangyuan @tenzen-y would you please take a look at this pr? thanks.

tenzen-y commented 1 year ago

My review queue is full. So I will review this PR this weekend or next week.

tenzen-y commented 1 year ago

@lowang-bh Can you fix CI errors?

?       github.com/kubeflow/mpi-operator/pkg/version    [no test files]
# github.com/kubeflow/mpi-operator/test/integration [github.com/kubeflow/mpi-operator/test/integration.test]
Error: test/integration/mpi_job_controller_test.go:734:50: undefined: common
FAIL    github.com/kubeflow/mpi-operator/test/integration [build failed]
FAIL
make: *** [Makefile:69: test] Error 2
Error: Process completed with exit code 2.

https://github.com/kubeflow/mpi-operator/actions/runs/5462212552/jobs/9941258951?pr=571#step:8:277

...
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369
# github.com/kubeflow/mpi-operator/test/e2e [github.com/kubeflow/mpi-operator/test/e2e.test]
Error: test/e2e/mpi_job_test.go:460:7: undefined: common
FAIL    github.com/kubeflow/mpi-operator/test/e2e [build failed]

https://github.com/kubeflow/mpi-operator/actions/runs/5462212552/jobs/9941259352?pr=571#step:4:3326

tenzen-y commented 1 year ago

cc: @alculquicondor

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor,terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 1 year ago

@terrytangyuan @alculquicondor Could you restart build / E2E (v1.27.1) (pull_request) ?

terrytangyuan commented 1 year ago

Done