Closed lowang-bh closed 1 year ago
@terrytangyuan @tenzen-y would you please take a look at this pr? thanks.
My review queue is full. So I will review this PR this weekend or next week.
@lowang-bh Can you fix CI errors?
? github.com/kubeflow/mpi-operator/pkg/version [no test files]
# github.com/kubeflow/mpi-operator/test/integration [github.com/kubeflow/mpi-operator/test/integration.test]
Error: test/integration/mpi_job_controller_test.go:734:50: undefined: common
FAIL github.com/kubeflow/mpi-operator/test/integration [build failed]
FAIL
make: *** [Makefile:69: test] Error 2
Error: Process completed with exit code 2.
https://github.com/kubeflow/mpi-operator/actions/runs/5462212552/jobs/9941258951?pr=571#step:8:277
...
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.2-0.20181231171920-c182affec369
# github.com/kubeflow/mpi-operator/test/e2e [github.com/kubeflow/mpi-operator/test/e2e.test]
Error: test/e2e/mpi_job_test.go:460:7: undefined: common
FAIL github.com/kubeflow/mpi-operator/test/e2e [build failed]
https://github.com/kubeflow/mpi-operator/actions/runs/5462212552/jobs/9941259352?pr=571#step:4:3326
cc: @alculquicondor
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alculquicondor, terrytangyuan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@terrytangyuan @alculquicondor Could you restart build / E2E (v1.27.1) (pull_request)
?
Done
Fix #564
TODO:
hack/python-sdk/gen-sdk.sh
did not finished due to lack of java runtime.