search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

strange backup in hack/python-sdk/gen-sdk.sh #572

Open lowang-bh opened 1 year ago

lowang-bh commented 1 year ago

  1. backup old generated file https://github.com/kubeflow/mpi-operator/blob/21f326d1d2e5f1beed667da0cc61e1d07158ef0c/hack/python-sdk/gen-sdk.sh#L32

  2. Then mv backup to cover new generated file event if new generated succeed https://github.com/kubeflow/mpi-operator/blob/21f326d1d2e5f1beed667da0cc61e1d07158ef0c/hack/python-sdk/gen-sdk.sh#L51

Why need to cover new generated file with old one?

tenzen-y commented 1 year ago

When we fail to generate codes on our local, we can restore original files from backup.

lowang-bh commented 1 year ago

When we fail to generate codes on our local, we can restore original files from backup.

But it will also cover new generated file when succeed, that's also as expect?