search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
419 stars 210 forks source link

Increase the timeout for E2E tests #576

Closed sheevy closed 1 year ago

sheevy commented 1 year ago

Similar to https://github.com/kubeflow/mpi-operator/pull/405

alculquicondor commented 1 year ago

I don't think individual tests are timing out. It's the whole suite that is timing out. Note that the default timeout for go test is 10 minutes, as documented here: https://pkg.go.dev/cmd/go#hdr-Testing_flags:~:text=sequence%2C%20if%20any.-,%2Dtimeout%20d,-If%20a%20test

You need to increase it in the Makefile

sheevy commented 1 year ago

Thanks. I've doubled that timeout to 20 minutes

alculquicondor commented 1 year ago

could you squash?

sheevy commented 1 year ago

ok, I failed trying to squash. I'll try once again. Is there a way to cancel the tests so I don't waste resources?

sheevy commented 1 year ago

ok, now squashing worked as intended

tenzen-y commented 1 year ago

Fix: #570

alculquicondor commented 1 year ago

/approve

google-oss-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment