search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
417 stars 209 forks source link

Remove unnecessary RBAC rule for mpijobs-admin*** #630

Open vishvajit79 opened 3 months ago

vishvajit79 commented 3 months ago

Update cluster-role.yaml to remove the unnecessary RBAC rule for mpijobs-admin.

Hello,

Thank you for reviewing this PR. I have removed the line rbac.authorization.kubeflow.org/aggregate-to-kubeflow-mpijobs-admin: "true" from the clusterrole as it was overriding the kubeflow-mpijobs-admin role with the kubeflow-mpijobs-edit role.

To clarify, the rbac.authorization.kubeflow.org/aggregate-to-kubeflow-mpijobs-admin annotation is used to aggregate the kubeflow-mpijobs-admin role to the kubeflow-mpijobs namespace. However, the previous implementation of this annotation was overriding the kubeflow-mpijobs-admin role with the kubeflow-mpijobs-edit role, which is more restrictive.

By removing this line, we are restoring the intended behavior of the kubeflow-mpijobs-admin role, allowing users with this role to manage MPI jobs in the kubeflow-mpijobs namespace.

Thank you for your attention to this matter.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment