search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
417 stars 209 forks source link

Upgrade K8s dependencies to v1.29 #633

Closed tenzen-y closed 2 months ago

tenzen-y commented 2 months ago

I upgraded the K8s dependencies to v1.29. Also, I upgraded the scheduler-plugins version to the latest (v1.28.9).

tenzen-y commented 2 months ago

/hold for https://github.com/kubeflow/mpi-operator/pull/631#discussion_r1568320647

alculquicondor commented 2 months ago

I think it's the easiest path if you include the golang upgrade here.

tenzen-y commented 2 months ago

I think it's the easiest path if you include the golang upgrade here.

I'll try to do it.

tenzen-y commented 2 months ago

@alculquicondor The Bumping Go version seems to depend on controller-gen version: https://github.com/kubeflow/mpi-operator/actions/runs/8722386744/job/23928137672?pr=633

So, I'd like to bump the go version in your PR.

alculquicondor commented 2 months ago

can you rebase?

tenzen-y commented 2 months ago

can you rebase?

I have rebased, but I faced other issues. So, I'm trying to investigate the issue.

tenzen-y commented 2 months ago

The eventChecker seems to be broken...

tenzen-y commented 2 months ago

The eventChecker seems to be broken...

NVM. I found another reason.

tenzen-y commented 2 months ago

@alculquicondor Could you take another look?

tenzen-y commented 2 months ago

/hold cancel

alculquicondor commented 2 months ago

/lgtm /approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)~~ [alculquicondor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment