search

kubeflow / mpi-operator

Kubernetes Operator for MPI-based applications (distributed training, HPC, etc.)
https://www.kubeflow.org/docs/components/training/mpi/
Apache License 2.0
430 stars 216 forks source link

Upgrade golang and controller-gen #636

Closed alculquicondor closed 5 months ago

alculquicondor commented 5 months ago

To prepare for release.

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from alculquicondor. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/mpi-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tenzen-y commented 5 months ago

@alculquicondor Could you follow this DCO step? https://github.com/kubeflow/mpi-operator/pull/636/checks?check_run_id=23927150703

alculquicondor commented 5 months ago

I missed make generate.

Fixed.

tenzen-y commented 5 months ago

I missed make generate.

Fixed.

@alculquicondor I guess that you missed make crd.

tenzen-y commented 5 months ago

I missed make generate. Fixed.

@alculquicondor I guess that you missed make crd.

NVM. There are any other reasons...

alculquicondor commented 5 months ago

Yeah, I don't know what I missed

tenzen-y commented 5 months ago

Yeah, I don't know what I missed

I found that your PR dropped some fields from swagger.json.

master branch: https://github.com/kubeflow/mpi-operator/blob/1b33fec7e3596fb45e843d44544692e1423f7489/pkg/apis/kubeflow/v2beta1/swagger.json#L159-L161 this PR: https://github.com/alculquicondor/mpi-operator/blob/973702775818aac7452963f594b43da5e732089a/pkg/apis/kubeflow/v2beta1/swagger.json#L159-L161

@alculquicondor Did make generate succeed in your local?

alculquicondor commented 5 months ago

Something is hexed in my local repo

/close

google-oss-prow[bot] commented 5 months ago

@alculquicondor: Closed this PR.

In response to [this](https://github.com/kubeflow/mpi-operator/pull/636#issuecomment-2061314246): >Something is hexed in my local repo > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.