search

kubeflow / mxnet-operator

A Kubernetes operator for mxnet jobs
Apache License 2.0
53 stars 34 forks source link

Update Contributing docs for recent go changes #58

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

As we migrate to go modules and update linter configs, I add a new page to give contributor more guidance on basic setup and development flow.

Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com

This change is Reviewable

Jeffwan commented 4 years ago

/cc @wackxu @suleisl2000

suleisl2000 commented 4 years ago

/ok-to-test

suleisl2000 commented 4 years ago

/lgtm

suleisl2000 commented 4 years ago

/approve

suleisl2000 commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mxnet-operator/blob/master/OWNERS)~~ [suleisl2000] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment