search

kubeflow / mxnet-operator

A Kubernetes operator for mxnet jobs
Apache License 2.0
53 stars 34 forks source link

Create separate clusterrole for mxnet-operator #70

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

Resolves #65.

This actually syncs some changes from my previous change in kubeflow/manifest https://github.com/kubeflow/manifests/pull/279. standalone manifest and kubeflow manifest will be consistent now.

Instead of using ClusterAdmin, we ceate a separate role mxnet-operator to fine grain control the permissions mxnet-operator needs.

We will use similar manifest in kubeflow/manifest.

Signed-off-by: Jiaxin Shan seedjeffwan@gmail.com

kubeflow-bot commented 4 years ago

This change is Reviewable

Jeffwan commented 4 years ago

/cc @terrytangyuan @suleisl2000 @wackxu

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mxnet-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment