search

kubeflow / mxnet-operator

A Kubernetes operator for mxnet jobs
Apache License 2.0
53 stars 34 forks source link

Add v1beta1 and v1 kustomize manifest #81

Closed Jeffwan closed 4 years ago

Jeffwan commented 4 years ago

part of #66

Since we have v1beta1 and v1 CRDs at the same time. It's better to have two manifests there for user to choose the version they like to apply in their cluster.

kubeflow-bot commented 4 years ago

This change is Reviewable

PatrickXYS commented 4 years ago

/lgtm

terrytangyuan commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mxnet-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment