search

kubeflow / mxnet-operator

A Kubernetes operator for mxnet jobs
Apache License 2.0
53 stars 34 forks source link

fix successPolicy logic #85

Closed jasonliu747 closed 4 years ago

jasonliu747 commented 4 years ago

Occasionally, scheduler would terminate before all workers have finished. This could fix it.

kubeflow-bot commented 4 years ago

This change is Reviewable

gaocegege commented 4 years ago

/lgtm

jasonliu747 commented 4 years ago

/assign terrytangyuan

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/mxnet-operator/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment