Open davidspek opened 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DavidSpek
To complete the pull request process, please assign terrytangyuan after the PR has been reviewed.
You can assign the PR to them by writing /assign @terrytangyuan
in a comment when ready.
The full list of commands accepted by this bot can be found here.
/assign @terrytangyuan
I am holding the PR to have some control over when it gets merged so that the optional test infra doesn't get overloaded if all the repo's were to merge this at the same time. /hold
Inspired by https://github.com/kubeflow/pipelines/issues/4682 I created a script that will create a config file for depandabot so that it knows what directories to scan. It will scan the repository for files named
*ockerfile*
,package*.json
,*requirements.txt
andgo.*
. It is setup for dockerfiles, npm packages, pip dependencies and gomod at the moment. It is trivial to further customize what folders are selected if further customization is needed. It also parses the closestOWNERS
file for a given dependency listing file, and assigns the relevant approvers and adds the relevant reviewers to the PRs it creates.This is a sibling PR to https://github.com/kubeflow/pipelines/pull/5015, https://github.com/kubeflow/kubeflow/pull/5542, https://github.com/kubeflow/kfserving/pull/1309, https://github.com/kubeflow/arena/pull/403, https://github.com/kubeflow/testing/pull/855, https://github.com/kubeflow/fairing/pull/550, https://github.com/kubeflow/kfp-tekton/pull/432, https://github.com/kubeflow/katib/pull/1420, https://github.com/kubeflow/tf-operator/pull/1224, https://github.com/kubeflow/kfp-tekton-backend/pull/28, https://github.com/kubeflow/mpi-operator/pull/319, https://github.com/kubeflow/pytorch-operator/pull/315, https://github.com/kubeflow/metadata/pull/255, https://github.com/kubeflow/xgboost-operator/pull/107 and https://github.com/kubeflow/fate-operator/pull/26.
As it stands now, there are about 8 PRs that will be created with this configuration.
For reference, the PRs that will be created can be found here: https://github.com/DavidSpek/mxnet-operator/pulls