kubeflow / mxnet-operator

A Kubernetes operator for mxnet jobs
Apache License 2.0
53 stars 34 forks source link

XGBoost Operator: Move manifests development upstream #89

Closed yanniszark closed 3 years ago

yanniszark commented 3 years ago

Background

Umbrella-Issue: https://github.com/kubeflow/manifests/issues/1740

As part of the work of wg-manifests for 1.3 (https://github.com/kubeflow/manifests/issues/1735), we are moving manifests development to upstream repos. This gives the application developers full ownership of their manifests, tracked in a single place.

To give an example from the notebook-controller, the diagram shows the current situation. Manifests are in two repos, blurring separation of responsibilities and making things harder for application developers.

diagram_1

Instead, we will copy all manifests from the manifests repo back to each upstream's repo. From there, they will be imported in the manifests repo. The following diagram presents the desired state:

diagram_2

Current State

XGBoost Operator has manifests:

Desired State

The proposed folder in the upstream repo to receive the manifests is: config.

The goal is to consolidate all manifests development in the upstream repo. The manifests repo will include a copy of the manifests under apps/xgboost-job/upstream. This copy will be synced periodically.

Success Criteria

The manifests in apps/xgboost-job/upstream should be a copy of the upstream manifests folder. To do that, the application manifests in kubeflow/manifests should be moved to the upstream application repo.

/assign @yanniszark cc @kubeflow/wg-training-leads

yanniszark commented 3 years ago

Wrong repo /close