search

kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
16 stars 11 forks source link

ci(ws): run `make test-e2e` on GitHub Actions #11

Closed jiridanek closed 2 months ago

jiridanek commented 5 months ago

This is something that works differently in new Kubebuilder, compared to what's in kubeflow/kubeflow notebook controller.

Previously, what they called e2e tests was running in envtest, but currently they expect to run in externally-provided kind. So, let's run this on CI as well, so we don't have dead code.

ederign commented 5 months ago

/lgtm

jiridanek commented 4 months ago

As per @thesuperzapper 's suggestion, I put in explicit kind version. Here's the CI running https://github.com/jiridanek/notebooks-v2/actions/runs/9602645980/job/26483942380

thesuperzapper commented 2 months ago

@jiridanek now that we have actual end-to-end tests (added in https://github.com/kubeflow/notebooks/pull/30), I have rebased this PR and cleaned it up a little in https://github.com/kubeflow/notebooks/pull/11/commits/3e8beea2bc92c46064ad22c84744ef51a7fb0e78 and https://github.com/kubeflow/notebooks/pull/11/commits/74089217f7eae491e1120c6bb1db03ea05d77f36.

We should be good to merge now, so that tests run automatically on every PR for the controller.

/lgtm /approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment