search

kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
18 stars 20 forks source link

feat(ws): add kubernetes client to backend #15

Closed ederign closed 5 months ago

ederign commented 5 months ago

closes https://github.com/kubeflow/notebooks/issues/12

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ederign commented 5 months ago

FYI: I just signed the CLA.

@thesuperzapper thank you so much for the help and guidance on this one.

thesuperzapper commented 5 months ago

/check-cla

thesuperzapper commented 5 months ago

@ederign you might need to force push so the bot rechecks

ederign commented 5 months ago

@thesuperzapper done!

thesuperzapper commented 5 months ago

@ederign thanks, lets move forward so we can use this in the next PR.

/approve /lgtm

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment