feat(ws): add `containerSecurityContext` to WorkspaceKind

kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.

Apache License 2.0

16 stars 11 forks source link

feat(ws): add `containerSecurityContext` to WorkspaceKind #20

Closed thesuperzapper closed 4 months ago

thesuperzapper commented 4 months ago

This PR brings the CRD spec into line with the latest updates from https://github.com/thesuperzapper/kubeflow-notebooks-v2-design/commit/7aeb44d4c7abf7977eed2ec2ce2d3309b935ba97.

The most important changes are:

Added a spec.podTemplate.containerSecurityContext to the WorkspaceKind
Made all optional CRD fields into pointers
- For example, we made WorkspacePodMetadata into *WorkspacePodMetadata
- NOTE: this is required to distinguish between unset and empty values, and is recommended by Kubernetes.
Updated the descriptions of CRD fields to keep them in line with the sample

thesuperzapper commented 4 months ago

@jiridanek @ederign @Adembc, for your reference.

thesuperzapper commented 4 months ago

@ederign while we wait for @jiridanek to be a member (so he can LGM), can you LGTM this so we can make future PRs based on it?

Since notebooks-v2 is not released its not a big deal if it's only a basic review.

thesuperzapper commented 4 months ago

@jiridanek thanks

/approve

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment