feat(ws): add `Workspace` and `WorkspaceKind` CRD scaffolds

kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.

Apache License 2.0

14 stars 8 forks source link

feat(ws): add `Workspace` and `WorkspaceKind` CRD scaffolds #6

Closed jiridanek closed 2 months ago

jiridanek commented 4 months ago

Followup on top of my:

https://github.com/kubeflow/notebooks/pull/5

Compared to the previous PR, WorkspaceKind must be created as cluster-wide resource, so

kubebuilder create api --version v1beta1 --kind WorkspaceKind --namespaced=false

(it has to be --namespaced=false; --namespaced false is ignored, see https://github.com/kubernetes-sigs/kubebuilder/issues/322#issuecomment-410104777)

Current CRD spec:

Todo's from meeting https://docs.google.com/document/d/1SiWLah-U07hAc47sSsoI8-NkbkLnHl1YVzxw193QUKE/edit#heading=h.naudedl8te2q

Make image .... httpPort into a list of ports (to allow multiple services per image)
Add a spec.spawner.deprecated: true/false
Add a spec.spawner.deprecatedMessage: “xxxxx”

jiridanek commented 3 months ago

@jiridanek I pushed a commit with some changes, I would appreciate you taking a look to see if I messed anything up: https://github.com/kubeflow/notebooks/commit/4dc0c160c6c32b66152f242569f20016ae42f4b0

looks good to me, thanks!

thesuperzapper commented 2 months ago

@jiridanek I did some small updates in https://github.com/kubeflow/notebooks/pull/6/commits/bb2ca34414619e732e400e925960fc6979043b7b (mostly adding a few fields to the Workspace status that are needed for the UI), but I also added some configs to make the kubectl get workspace and kubectl get workspacekind more useful.

I am going to merge this now, so we can start the reconciliation loop PR (we can make any further changes in that PR).

/lgtm /approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment