search

kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
18 stars 19 forks source link

chore(ws): restructure frontend and setup navigation #67

Closed Griffin-Sullivan closed 1 month ago

Griffin-Sullivan commented 1 month ago

Restructuring the frontend to have the right directory layout. I also updated some things like README, package.json, tsconfig, webpack config, and added routes / navigation.

Most of this reflects how model registry is set up.

ederign commented 1 month ago

/lgtm thank you so much Griffin! Let's move forward and work on the next PR

ederign commented 1 month ago

/lgtm

thesuperzapper commented 1 month ago

@Griffin-Sullivan @ederign I think something about what you changed requires the frontend test GitHub workflow to be updated:

It's probably best if we try and get it to pass before merging, unless you have already started another PR based on this one.

Griffin-Sullivan commented 1 month ago

Do I need to become a member of Kubeflow for the workflow to run without approval?

thesuperzapper commented 1 month ago

Do I need to become a member of Kubeflow for the workflow to run without approval?

@Griffin-Sullivan, no once you get your first PR merged on the repo it will be fine.

I just approved it for now.

Griffin-Sullivan commented 1 month ago

apparently no tests == fail..... I'll add back the Jest test I removed and then re-remove when I add Cypress in the next PR.

Griffin-Sullivan commented 1 month ago

Ok so instead I actually removed the test run step from the GitHub Action since the test is out of date and there's no point to add tests right now when we will start that in the next PR.

thesuperzapper commented 1 month ago

@Griffin-Sullivan it looks like the CI is still failing, cant you just add a nothing test, and ensure that all the other steps in the GitHub workflow succeed?

That will make it easier when we add new tests.

Griffin-Sullivan commented 1 month ago

I could but I see that as pointless work when I could just fix the github action. Looks like I accidentally removed an npm command that should've stayed.

Griffin-Sullivan commented 1 month ago

Ok fairly confident in this one :laughing:

thesuperzapper commented 1 month ago

@Griffin-Sullivan we can merge this for now, but please remember to re-add the test call in the github action in your next PR, otherwise we will probably forget.

/lgtm /approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment