kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.59k stars 1.62k forks source link

[frontend] Filter pipeline text box shows error when typing anything in it #10241

Closed czchen closed 1 month ago

czchen commented 10 months ago

Environment

Steps to reproduce

List request failed with:
{"error":"Failed to list pipelines due invalid list options: pageToken: , pageSize: 10, sortBy: created_at desc, filter: %7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D: Invalid input error: failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate","code":3,"message":"Failed to list pipelines due invalid list options: pageToken: , pageSize: 10, sortBy: created_at desc, filter: %7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D: Invalid input error: failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate","details":[{"@type":"type.googleapis.com/google.rpc.Status","code":3,"message":"failed to parse valid filter from \"%7B%22predicates%22%3A%5B%7B%22key%22%3A%22name%22%2C%22op%22%3A%22IS_SUBSTRING%22%2C%22string_value%22%3A%22a%22%7D%5D%7D\": unknown field \"op\" in kubeflow.pipelines.backend.api.v2beta1.Predicate"}]}

Expected result

There shall be no error message when typing in Filter pipelines input box.

Materials and Reference


Impacted by this bug? Give it a 👍.

lethee commented 9 months ago

I have same issue.

Predicate:

{
    "predicates": [
        {
            "key": "name",
            "op": "IS_SUBSTRING",
            "string_value": "d"
        },
        {
            "key": "storage_state",
            "operation": "NOT_EQUALS",
            "string_value": "ARCHIVED"
        }
    ]
}

My env:

{
    "buildDate": "Fri Oct 27 04:09:58 UTC 2023",
    "frontendCommitHash": "58ce09e07d031964905020c749e77bf0f37e83d4",
    "frontendTagName": "2.0.3",
    "apiServerReady": true,
    "apiServerCommitHash": "58ce09e07d031964905020c749e77bf0f37e83d4",
    "apiServerTagName": "2.0.3",
    "apiServerMultiUser": true,
    "multi_user": true
}
Screenshot 2024-01-04 at 11 31 26 AM

I think problem is on https://github.com/kubeflow/pipelines/blob/master/frontend/src/components/CustomTable.tsx#L545

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 6 months ago

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

tom-pavz commented 3 months ago

We are still seeing this exact bug in KFP backend 2.1.0

HumairAK commented 3 months ago

/re-open

HumairAK commented 3 months ago

/reopen

google-oss-prow[bot] commented 3 months ago

@HumairAK: Reopened this issue.

In response to [this](https://github.com/kubeflow/pipelines/issues/10241#issuecomment-2155224390): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
thesuperzapper commented 3 months ago

@droctothorpe given your work on https://github.com/kubeflow/pipelines/pull/10797, I wonder if you have also seen this issue?

It seems like the first time you try and create a new run by:

  1. Going to the "Runs" page
  2. Clicking "Create Run"
  3. Clicking "Choose" pipeline
  4. Finding a pipeline and clicking "Use this Pipeline"

You will get a crazy slow response, or sometimes you will get an error like what this issue raises.

droctothorpe commented 3 months ago

We've noticed this as well! Haven't had a chance to debug it yet though.

thesuperzapper commented 3 months ago

@droctothorpe The issue I am talking about in https://github.com/kubeflow/pipelines/issues/10241#issuecomment-2156129113 seems to be different from the one raised by @czchen in this issue, sorry. I have raised a separate issue for that: https://github.com/kubeflow/pipelines/issues/10897

The issue is raised by @czchen is still very important because it's actually a broken feature (filtering literally does not work in V2).

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

HumairAK commented 1 month ago

/remove-lifecycle stale

ElayAharoni commented 1 month ago

/assign

boarder7395 commented 1 month ago

Tested this in 2.2.0 and search is still broken. I took a look at https://github.com/kubeflow/pipelines/pull/10358 and while it fixes the create run page, it breaks the clone from run page.

Create Run Page Error on 2.2.0: Screenshot 2024-08-15 at 2 39 08 PM

Clone Run Page Error with fix #10358 and #11096 Screenshot 2024-08-15 at 3 11 05 PM