search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.5k stars 1.58k forks source link

[sdk] Update requests-toolbelt dependencies #10470

Open alanhdu opened 4 months ago

alanhdu commented 4 months ago

Currently, kfp pins requests-toolbelt < 1. Would it be possible to support requests-toolbelt=1.0? From the release notes, I doubt any of the breaking changes affect kfp.

w/o this, it becomes impossible to use kfp with other dependencies that require reuqests-toolbelt 1.0.

rimolive commented 3 months ago

cc @connor-mccarthy

chensun commented 3 months ago

Please feel free to open a PR and validate through our presubmit test first.

Edit: @connor-mccarthy mentioned there might be an issue caused by some transitive dependency, but feel free to use a PR to revalidate it.

SimonDR-Boltzmann commented 2 months ago

This is affecting repositories with poetry as the new poetry 1.8.* requires requests-toolbelt>=1 I created a pr here: https://github.com/kubeflow/pipelines/pull/10762 (disregard the failed attempts please :grimacing: )

github-actions[bot] commented 4 days ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.