search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.53k stars 1.59k forks source link

[feature] Mounting emptyDir option on kfp v2 workflow-task using kfp-kubernetes #10656

Open harshad16 opened 4 months ago

harshad16 commented 4 months ago

Feature Area

/area sdk

What feature would you like to see?

In kfp-kubernetes SDK can we include add_volume function. as in the kfp dsl, we had the option in kfp v1 https://github.com/kubeflow/pipelines/blob/f80bfd4e07565f0a95ccebcf5abd8e9a7ae2627f/sdk/python/kfp/deprecated/dsl/_container_op.py#L934 Use case is to have an option to volumes to the workflow tasks.

What is the use case or pain point?

In (kfp v2) kfp-kubernetes only provides the add_pvc and mount_pvc options. As currently , there is no option to mount , emptyDir secretes and configmaps can be mounted separately.

https://github.com/kubeflow/pipelines/blob/master/kubernetes_platform/python/kfp/kubernetes/volume.py

Is there a workaround currently?

No. use older deprecated version.

Love this idea? Give it a 👍.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gregsheremeta commented 1 month ago

not stale ... i'm working on it

thesuperzapper commented 3 weeks ago

It looks like there is a PR to add this important feature in https://github.com/kubeflow/pipelines/pull/10913, but I am not sure about its status.

Can one of @gregsheremeta @hbelmiro @droctothorpe @rimolive confirm what we need to do to get that merged?

If you are wondering why this is important, it's because PyTorch expects there to be a tempfs mounted at /dev/shm, and the only way to ensure this in a Kubernetes Pod is to mount an emptyDir with medium="Memory" to it.

gregsheremeta commented 3 weeks ago

confirm what we need to do to get that merged?

We need one of the Google maintainers to review it. Chen is out until July 22. It doesn't appear that Connor works on this project anymore.