Migrate presubmit tests to GH Actions

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.6k stars 1.62k forks source link

Migrate presubmit tests to GH Actions #10746

Closed rimolive closed 2 weeks ago

rimolive commented 5 months ago

Description

As part of the main tracker issue, we need to migrate presubmit tests to GH Actions.

Acceptance Criteria

Need to be able to run locally (preferrable using KinD)
Need to implement artifact generation (workflow example, and script example

Impacted by this bug? Give it a 👍.

rimolive commented 5 months ago

/remove-kind bug /kind feature /good-first-issue

google-oss-prow[bot] commented 5 months ago

@rimolive: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubeflow/pipelines/issues/10746): >/remove-kind bug >/kind feature >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

pratikkumar-mohite commented 4 months ago

I would like to work on this, if no one is working, please assign

kark7 commented 3 months ago

/assign

kark7 commented 3 months ago

/unassign

liavweiss commented 2 months ago

Hey @rimolive, regarding the presubmit tests, does the "tests" mean all the presubmit tests that are still not on Git Hub action?

presubmit-tests-tfx.sh
presubmit-tests-with-pipeline-deployment.sh ?

liavweiss commented 2 months ago

I'm interested in working on this issue, I am waiting for an answer to the question above. /assign

hbelmiro commented 2 months ago

@liavweiss there's only one test that we still need to migrate: https://github.com/kubeflow/pipelines/issues/11052 It doesn't seem a trivial one though. If you want to try it, you can use https://github.com/kubeflow/pipelines/pull/11048 as a reference.

Other issues that you can work on are:

liavweiss commented 2 months ago

ok thanks for the answer, I won't work on it.

liavweiss commented 2 months ago

/unassign

sky0walker99 commented 2 weeks ago

I’d like to contribute to this issue and work on the remaining test migration. I will refer to #11048 as suggested. Please let me know if there are any additional details or steps I should follow before getting started. /assign

hbelmiro commented 2 weeks ago

@sky0walker99 thank you for trying to contribute. But this was already done.

/close

google-oss-prow[bot] commented 2 weeks ago

@hbelmiro: Closing this issue.

In response to [this](https://github.com/kubeflow/pipelines/issues/10746#issuecomment-2381457807): >@sky0walker99 thank you for trying to contribute. But this was already done. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.