search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.55k stars 1.6k forks source link

[feature] Support S3 virtual hosted style #10814

Open sanchesoon opened 4 months ago

sanchesoon commented 4 months ago

Feature Area

/area backend

What feature would you like to see?

To be able use Virtual Host Style S3 protocol we should provide configuration option. Because "by default, the S3 client will use virtual hosted bucket addressing when possible." According aws-sdk-go documentation.

What is the use case or pain point?

Ability to switch between Virtual Host and Path Style

Is there a workaround currently?

There is no work round for this. Because this is hardcoded https://github.com/kubeflow/pipelines/blob/master/backend/src/v2/objectstore/object_store.go#L260

Love this idea? Give it a 👍.

HumairAK commented 4 months ago

/assign @HumairAK

thesuperzapper commented 4 months ago

@sanchesoon what additional benefit would this give us?

I am pretty sure it would take a lot of work, which would be better spent on other problems which actually affect the user experience.

sanchesoon commented 3 months ago

@thesuperzapper It give us ability to use Virtual Host style. Not sure if here a lot work, should be just additional parameter to pass launcher (but I never did PR here) BTW this was fixed in argo workflow https://github.com/argoproj/pkg/pull/368/files

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

HumairAK commented 1 month ago

/remove-lifecycle stale