test: Moved kfp-kubernetes-execution-tests to GitHub Actions

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.5k stars 1.57k forks source link

test: Moved kfp-kubernetes-execution-tests to GitHub Actions #10926

Open hbelmiro opened 1 week ago

hbelmiro commented 1 week ago

Description of your changes: Moved kfp-kubernetes-execution-tests to GitHub Actions.

Resolves: https://github.com/kubeflow/pipelines/issues/10921

Implementation notes

I had to use Ubuntu 24.04 because the default (22.04) has an old and non-compatible version of protobuf-compiler.
- apt-get update was not enough to get it updated
- I also tried to manually install the binary, but it didn't work
Python 3.8 is not available in the Ubuntu 24.04 runner. So I didn't include it in the matrix.

PR to update GoogleCloudPlatform/oss-test-infra

https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2304

Checklist:

[x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow[bot] commented 1 week ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] commented 1 week ago

@hbelmiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
kfp-kubernetes-execution-tests	a965f783bf3554cb199840df612b60bbb68e0c2d	link	false	`/test kfp-kubernetes-execution-tests`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

hbelmiro commented 1 week ago

/assign @DharmitD @chensun

rimolive commented 1 week ago

@hbelmiro Prow tests run kfp-kubernetes testing using Python 3.8 to 3.12. From what I can see in this PR, GHA kfp-kubernetes testing is not checking Python 3.8. Can you add this version too?

hbelmiro commented 1 week ago

@hbelmiro Prow tests run kfp-kubernetes testing using Python 3.8 to 3.12. From what I can see in this PR, GHA kfp-kubernetes testing is not checking Python 3.8. Can you add this version too?

@rimolive I added a note about that in the description of the PR.

hbelmiro commented 5 days ago

cc @chensun @zijianjoy @james-jwu

hbelmiro commented 4 days ago

/hold for rebasing after https://github.com/kubeflow/pipelines/pull/10946 gets merged.

hbelmiro commented 1 day ago

/unhold /approve

google-oss-prow[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hbelmiro Once this PR has been reviewed and has the lgtm label, please ask for approval from chensun. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - ~~[.github/OWNERS](https://github.com/kubeflow/pipelines/blob/master/.github/OWNERS)~~ [hbelmiro] - **[kubernetes_platform/OWNERS](https://github.com/kubeflow/pipelines/blob/master/kubernetes_platform/OWNERS)** - ~~[test/OWNERS](https://github.com/kubeflow/pipelines/blob/master/test/OWNERS)~~ [hbelmiro] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

hbelmiro commented 1 day ago

We still need your approval on this @chensun.