Open etheleon opened 1 month ago
Hey @etheleon this looks like the kustomize manifest files need to be updated, you can grep for all occurrences of these in the manifests
folder example here:
# from manifests/ folder
$ grep -r "commonLabels" .
./kustomize/base/cache-deployer/kustomization.yaml:commonLabels:
./kustomize/base/cache/kustomization.yaml:commonLabels:
./kustomize/base/installs/multi-user/cache/kustomization.yaml:commonLabels:
./kustomize/base/installs/multi-user/pipelines-profile-controller/kustomization.yaml:commonLabels:
./kustomize/base/installs/multi-user/pipelines-ui/kustomization.yaml:commonLabels:
./kustomize/base/installs/multi-user/kustomization.yaml:commonLabels:
./kustomize/env/aws/kustomization.yaml:commonLabels:
./kustomize/env/azure/kustomization.yaml:commonLabels:
./kustomize/env/cert-manager/base/kustomization.yaml:commonLabels:
./kustomize/env/dev/postgresql/kustomization.yaml:commonLabels:
./kustomize/env/dev/kustomization.yaml:commonLabels:
./kustomize/env/gcp/kustomization.yaml:commonLabels:
./kustomize/env/platform-agnostic-multi-user/kustomization.yaml:commonLabels:
./kustomize/env/openshift/kustomization.yaml:commonLabels:
./kustomize/env/platform-agnostic-multi-user-legacy/kustomization.yaml:commonLabels:
./kustomize/env/platform-agnostic-postgresql/kustomization.yaml:commonLabels:
./kustomize/env/plain-multi-user/kustomization.yaml:commonLabels:
./kustomize/env/platform-agnostic-tekton-multi-user/kustomization.yaml:commonLabels:
./kustomize/sample/kustomization.yaml:commonLabels:
./kustomize/third-party/argo/upstream/manifests/quick-start/sso/dex/kustomization.yaml:commonLabels:
./kustomize/third-party/metacontroller/base/kustomization.yaml:commonLabels:
Docs for this are here: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/labels/ If you are unfamiliar with kustomize, you can learn about it here: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/#overview-of-kustomize
Let me know if you'd like to take this on, I can assign you!
Would love to take this on! Assign this to me and I'll get to work
/assign etheleon
Hi @HumairAK, there's multiple resources are impacted by this change, should i submit this as a single PR?
How can I test this?
Also I've created a draft PR https://github.com/kubeflow/pipelines/pull/11289
@HumairAK, the list you provided, manifests meant for the openshift
environment cant be found on the master branch anymore
I was probably on a separate fork, so I wouldn't use my list as the source of truth here, rather just run the same command in the kubeflow master branch
Hi @HumairAK, there's multiple resources are impacted by this change, should i submit this as a single PR?
that would be ideal, yes, I've added this to 2.4 milestone, so I'll try get some eyes on this, thank you!
Environment
How did you deploy Kubeflow Pipelines (KFP)? I deployed KFP on my standalone workstation running Ubuntu 24.04 LTS
KFP version: 2.3.0
Steps to reproduce
Followed instructions from https://www.kubeflow.org/docs/components/pipelines/operator-guides/installation/
When applying the last command i got a couple of
commonLabels
is deprecated warning.I would love to work on this could anyone guide me?
Impacted by this bug? Give it a 👍.