Closed CarterFendley closed 1 month ago
Hi @CarterFendley. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hbelmiro
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description of your changes:
This PR is an MVP which gets the images built and deployments patched to use those images. The PR is intended to be iterated on with more formalization / improvement in the future while also getting testing working in the meantime. This addition is related to #11239, but also makes changes related to
apiserver
,persistenceagent
, andscheduledworkflow
images, more discussion will be added to that issue.The PR primarily modifies the scripts in
scripts/deploy/github/
which are used by the GitHub action here. Thekubectl patch
command is used to patch deployment images, andkubectl set env
to modify environment variables.Other changes
Some minor changes were made to the wait_for_pods.py tooling, to display more information in cases where there are errors. See the screenshot below of a case in which this helped me while working on this PR :P
Checklist:
Other comments
Since we are building more images, this does slow down the workflows a bit (
~17min
->~22min
), will try to think if we can speed that up a little because 22 minute waits are painful.