Find a better solution for using images built in PRs in deploy-kfp.sh

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.6k stars 1.62k forks source link

Find a better solution for using images built in PRs in deploy-kfp.sh #11293

Open hbelmiro opened 1 week ago

hbelmiro commented 1 week ago

Currently deploy-kfp.sh is patching the deployments to set the images. We need to find a better solution. Maybe using kustomize?

This issue depends on:

https://github.com/kubeflow/pipelines/issues/11239

Labels

/area testing

Impacted by this bug? Give it a 👍.

CarterFendley commented 1 week ago

What's up homies.

I opened #11294 to add this for Argo setups. It looks like the tekton action already uses a kustomization.yaml for its' setup.

This file has configurations for the apiserver, persistenceagent, and scheduledworkflow but no patches for the driver / launcher. Since all of this stuff is the same, I am wondering if I should try to pull out these images configurations into a common file?

I am not 100% certain on the tekton side of things, so please add info where helpful.

hbelmiro commented 6 days ago

I believe both ArgoWF and Tekton use the same images. @rimolive can you confirm it?

rimolive commented 6 days ago

Not really. In KFP 2.2.0 we did not finish the kfp-tekton code merge, so if you need to use tekton you will still require a separate image.