feat(testing): use kustomize to patch deployments before deploy

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow

https://www.kubeflow.org/docs/components/pipelines/

Apache License 2.0

3.62k stars 1.63k forks source link

feat(testing): use kustomize to patch deployments before deploy #11294

Closed CarterFendley closed 1 month ago

CarterFendley commented 1 month ago

Description of your changes:

This PR is a followup to #11284 which removes the kubectl patch commands by introducing a kustomization. This is in attempt to solve #11293, although does not yet address the Tekton side of things.

Feedback wanted:

Should this new kustomization.yaml be moved to manifests/kustomize/env?

Checklist:

[x] You have signed off your commits
[x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow[bot] commented 1 month ago

Hi @CarterFendley. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

DharmitD commented 1 month ago

I don't have a strong opinion. In case we decide to move, we should move it to a new test directory and include this directory in the paths that trigger tests. If we leave them where they are, we don't need to change anything else?

+1, no need to move as such, but if we decide to move it, make sure to create a new test directory and also move the overlays directory too.

CarterFendley commented 1 month ago

The recent additions to the PR move the contents of scripts/deploy/github to .github/resources/ manifests have been seperated in to two different directories. This structure was suggested in slack here.

.github/resources/manifests/argo
.github/resources/manifests/tekton

There is some similarity between the Argo testing kustomization and the Tekton ones, but as per discussion in that slack thread, tekton will be tracked by #11292 and not handled in this PR.

rimolive commented 1 month ago

/rerun-all

hbelmiro commented 1 month ago

@CarterFendley can you please rebase?

rimolive commented 1 month ago

/lgtm

The tests passed in the new paths

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.github/OWNERS](https://github.com/kubeflow/pipelines/blob/master/.github/OWNERS)~~ [DharmitD] - ~~[scripts/OWNERS](https://github.com/kubeflow/pipelines/blob/master/scripts/OWNERS)~~ [DharmitD] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment