kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

test: Fix failing SDK tests by creating Python virtual environment #11300

Closed VaniHaripriya closed 1 month ago

VaniHaripriya commented 1 month ago

Description of your changes:

Resolves the failing KFP SDK Tests -https://github.com/kubeflow/pipelines/actions/runs/11351867593/job/31573385411

Checklist:

google-oss-prow[bot] commented 1 month ago

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/kubeflow/pipelines/blob/master/test/OWNERS)~~ [hbelmiro] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbelmiro commented 1 month ago

But we probably need to to the same for all workflows that run pip install.

Can you please send a follow up PR for the other ones?

@VaniHaripriya everything is passing now. I think we can ignore the other ones for now and keep an eye on the CI.