kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

chore(components): move old components to contrib folder #11315

Closed chensun closed 1 month ago

chensun commented 1 month ago

Moving components that has no maintenance activities in the past two years to the contrib folder.

Description of your changes:

Checklist:

HumairAK commented 1 month ago

I think my overall preference is to remove these entirely to lower maintenance burden, as well as reduce noise from security scan software, but this works too.

/lgtm /approve

related: https://github.com/kubeflow/pipelines/issues/11145

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[components/OWNERS](https://github.com/kubeflow/pipelines/blob/master/components/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Fiona-Waters commented 1 month ago

I currently have this PR updating the pytorch-launcher component. Is this work still relevant? Related issue @anishasthana @HumairAK @chensun cc @Shreyanand

HumairAK commented 1 month ago

@Fiona-Waters yes, absolutely, in this case my suggestion is to rebase and just re-add the files that are being updated, but not the files that have not been updated in a while