kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

fix(ui): turn off GKE metadata by default #11321

Open gregsheremeta opened 1 month ago

gregsheremeta commented 1 month ago

Description of your changes:

Since GKE is only one of many platforms, change the default value of DISABLE_GKE_METADATA to true. Edit the gcp manifest to override that to false on GCP.

Fixes: #11247

Checklist:

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[frontend/OWNERS](https://github.com/kubeflow/pipelines/blob/master/frontend/OWNERS)** - **[manifests/kustomize/OWNERS](https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
HumairAK commented 1 month ago

the frontend failures here are relevant:

Details

``` FAIL ./app.test.ts ● Console console.log integration-tests/test-helper.ts:1867 beforeAll, writing files console.info node_modules/http-proxy-middleware/lib/logger.js:81 [HPM] Proxy created: / -> http://localhost:9090 ● UIServer apis › /system › /cluster-name › responds with cluster name data from gke metadata expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:268:12) at Test._assertFunction (node_modules/supertest/lib/test.js:283:11) at Test.assert (node_modules/supertest/lib/test.js:173:18) at localAssert (node_modules/supertest/lib/test.js:131:12) at node_modules/supertest/lib/test.js:128:5 at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3) at IncomingMessage. (node_modules/superagent/lib/node/index.js:916:18) ● UIServer apis › /system › /cluster-name › responds with 500 status code if corresponding endpoint is not ok expected 'Failed fetching GKE cluster name' response body, got 'GKE metadata endpoints are disabled.' at error (node_modules/supertest/lib/test.js:301:13) at Test._assertBody (node_modules/supertest/lib/test.js:218:14) at Test._assertFunction (node_modules/supertest/lib/test.js:283:11) at Test.assert (node_modules/supertest/lib/test.js:173:18) at localAssert (node_modules/supertest/lib/test.js:131:12) at node_modules/supertest/lib/test.js:128:5 at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3) at IncomingMessage. (node_modules/superagent/lib/node/index.js:916:18) ● UIServer apis › /system › /project-id › responds with project id data from gke metadata expected 200 "OK", got 500 "Internal Server Error" at Test._assertStatus (node_modules/supertest/lib/test.js:268:12) at Test._assertFunction (node_modules/supertest/lib/test.js:283:11) at Test.assert (node_modules/supertest/lib/test.js:173:18) at localAssert (node_modules/supertest/lib/test.js:131:12) at node_modules/supertest/lib/test.js:128:5 at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3) at IncomingMessage. (node_modules/superagent/lib/node/index.js:916:18) ● UIServer apis › /system › /project-id › responds with 500 status code if metadata request is not ok expected 'Failed fetching GKE project id' response body, got 'GKE metadata endpoints are disabled.' at error (node_modules/supertest/lib/test.js:301:13) at Test._assertBody (node_modules/supertest/lib/test.js:218:14) at Test._assertFunction (node_modules/supertest/lib/test.js:283:11) at Test.assert (node_modules/supertest/lib/test.js:173:18) at localAssert (node_modules/supertest/lib/test.js:131:12) at node_modules/supertest/lib/test.js:128:5 at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3) at IncomingMessage. (node_modules/superagent/lib/node/index.js:916:18) ```

so we'd need to address those somehow