Open gregsheremeta opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
the frontend failures here are relevant:
```
FAIL ./app.test.ts
● Console
console.log integration-tests/test-helper.ts:1867
beforeAll, writing files
console.info node_modules/http-proxy-middleware/lib/logger.js:81
[HPM] Proxy created: / -> http://localhost:9090
● UIServer apis › /system › /cluster-name › responds with cluster name data from gke metadata
expected 200 "OK", got 500 "Internal Server Error"
at Test._assertStatus (node_modules/supertest/lib/test.js:268:12)
at Test._assertFunction (node_modules/supertest/lib/test.js:283:11)
at Test.assert (node_modules/supertest/lib/test.js:173:18)
at localAssert (node_modules/supertest/lib/test.js:131:12)
at node_modules/supertest/lib/test.js:128:5
at Test.Request.callback (node_modules/superagent/lib/node/index.js:728:3)
at IncomingMessage.
so we'd need to address those somehow
Description of your changes:
Since GKE is only one of many platforms, change the default value of
DISABLE_GKE_METADATA
totrue
. Edit the gcp manifest to override that tofalse
on GCP.Fixes: #11247
Checklist: