search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.62k stars 1.63k forks source link

feat(api): add PipelineConfig to api to re-implement pipeline-level config #11333

Closed gregsheremeta closed 3 weeks ago

gregsheremeta commented 4 weeks ago

Description of your changes:

KFP v1 supported setting pipeline-level configuration via a PipelineConf class. This class was deprecated and no replacement was added to KFP v2.

add new PipelineConfig message in the api to support setting pipeline-level configuration in KFP v2.

companion to #11112. #11333 has to be merged first.

Checklist:

rimolive commented 4 weeks ago

/lgtm

gregsheremeta commented 3 weeks ago

I suggest complementing this comment to tell that this PR has to be merged before https://github.com/kubeflow/pipelines/pull/11112.

done

HumairAK commented 3 weeks ago

/lgtm /approve

google-oss-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[api/OWNERS](https://github.com/kubeflow/pipelines/blob/master/api/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gregsheremeta commented 3 weeks ago

Note for anyone looking at this or relying on it: I'm not positive that it was ok to bump the version here, but I'm looking into it. I see other examples where we've done a similar bump. I've added this as a topic for the next SIG meeting.

HumairAK commented 3 weeks ago

fyi @chensun

gregsheremeta commented 2 weeks ago

Note for anyone looking at this or relying on it: I'm not positive that it was ok to bump the version here, but I'm looking into it. I see other examples where we've done a similar bump. I've added this as a topic for the next SIG meeting.

Cancel the alarm. It's fine. My full write up on why:

November 5, 2024 - protoc versions - Google Docs https://docs.google.com/document/d/19NF4NiZToLvP6Vp8fDleSsdkyK5fjv_jd8k1FCflyLQ/edit?tab=t.0

We can go over it at tomorrow's meeting.